diff options
| author | NRK <nrk@disroot.org> | 2022-07-15 22:46:23 +0200 |
|---|---|---|
| committer | NRK <nrk@disroot.org> | 2022-07-15 22:46:23 +0200 |
| commit | c131b1ed83da70fd739aff90ea3e8e829549ff43 (patch) | |
| tree | f844587cc09b209c0edee2d3649589d62bc07215 /.woodpecker/CFLAGS | |
| parent | 5cab2fb52520e6a24012351b936ebb9162494666 (diff) | |
| download | nsxiv-c131b1ed83da70fd739aff90ea3e8e829549ff43.tar.zst | |
fix: -Wsign-compare warnings (#336)
mixing signed and unsigned types in comparison can end up having
unintended results. for example:
if (-1 < 1U)
printf("true\n");
else
printf("false\n");
previously we silenced these warnings, instead just fix them properly
via necessary casting, and in cases where the value cannot be negative
(e.g width/height members) make them unsigned.
Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/336
Reviewed-by: explosion-mental <explosion-mental@noreply.codeberg.org>
Diffstat (limited to '.woodpecker/CFLAGS')
| -rw-r--r-- | .woodpecker/CFLAGS | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.woodpecker/CFLAGS b/.woodpecker/CFLAGS index df24be7..57d7d16 100644 --- a/.woodpecker/CFLAGS +++ b/.woodpecker/CFLAGS @@ -10,4 +10,4 @@ -Wbad-function-cast -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes # silence --Wno-sign-compare -Wno-unused-parameter -Wno-missing-field-initializers +-Wno-unused-parameter -Wno-missing-field-initializers |