aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorN-R-K <79544946+N-R-K@users.noreply.github.com>2021-09-21 21:53:11 +0200
committerGitHub <noreply@github.com>2021-09-21 21:53:11 +0200
commitc093eae9712e79cba958ab49457b4f2912fd95d7 (patch)
tree2797bc664e118c96bd03f9cded65bc7b2cf99148
parent9c3310b6761513e9454f293bd6cfcc6cf7f54921 (diff)
downloadnsxiv-c093eae9712e79cba958ab49457b4f2912fd95d7.tar.zst
code-style: use constant length array (#79)
currently the code-base doesn't make use of variable length array despite being -std=c99. it was irresponsible of me to introduce VLA in here. since this function will be called quite often, i did not want to make calls to malloc and free as they have some overhead. 512 should be sufficient enough and probably is far bigger than any window title bar can display anyways.
-rw-r--r--window.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/window.c b/window.c
index 7e58a19..a8597d3 100644
--- a/window.c
+++ b/window.c
@@ -493,7 +493,7 @@ void win_draw_rect(win_t *win, int x, int y, int w, int h, bool fill, int lw,
void win_set_title(win_t *win, const char *path)
{
- const unsigned int title_max = strlen(path) + strlen(options->title_prefix) + 1;
+ enum { title_max = 512 };
char title[title_max];
const char *basename = strrchr(path, '/') + 1;