centralize script handling logic (#477)

currently the logic of when to open/close script is scattered around the
entire code-base which is both ugly and error-prone.

this patch centralizes script handling by remembering the relevant
information on each redraw and then comparing it with the previous
information to figure out whether something changed or not.

this also fixes a bug where scripts weren't being called in thumbnail
mode when mouse was used for selecting a different image.

Closes: https://codeberg.org/nsxiv/nsxiv/issues/475

Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/477
Reviewed-by: eylles <eylles@noreply.codeberg.org>

1 files changed, 1 insertions, 9 deletions

diff --git a/commands.c b/commands.c
index 97cadf2..3257b1e 100644
--- a/commands.c
+++ b/commands.c
@@ -83,9 +83,6 @@ bool cg_switch_mode(arg_t _)
 		load_image(fileidx);
 		mode = MODE_IMAGE;
 	}
-	close_info();
-	open_info();
-	title_dirty = true;
 	return true;
 }
 
@@ -415,12 +412,7 @@ bool ci_slideshow(arg_t _)
 
 bool ct_move_sel(arg_t dir)
 {
-	bool dirty = tns_move_selection(&tns, dir, prefix);
-	if (dirty) {
-		close_info();
-		open_info();
-	}
-	return dirty;
+	return tns_move_selection(&tns, dir, prefix);
 }
 
 bool ct_reload_all(arg_t _)