diff options
author | NRK <nrk@disroot.org> | 2022-07-15 22:46:23 +0200 |
---|---|---|
committer | NRK <nrk@disroot.org> | 2022-07-15 22:46:23 +0200 |
commit | c131b1ed83da70fd739aff90ea3e8e829549ff43 (patch) | |
tree | f844587cc09b209c0edee2d3649589d62bc07215 /commands.c | |
parent | 5cab2fb52520e6a24012351b936ebb9162494666 (diff) | |
download | nsxiv-c131b1ed83da70fd739aff90ea3e8e829549ff43.tar.zst |
fix: -Wsign-compare warnings (#336)
mixing signed and unsigned types in comparison can end up having
unintended results. for example:
if (-1 < 1U)
printf("true\n");
else
printf("false\n");
previously we silenced these warnings, instead just fix them properly
via necessary casting, and in cases where the value cannot be negative
(e.g width/height members) make them unsigned.
Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/336
Reviewed-by: explosion-mental <explosion-mental@noreply.codeberg.org>
Diffstat (limited to 'commands.c')
-rw-r--r-- | commands.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -36,7 +36,7 @@ bool cg_quit(arg_t status) unsigned int i; if (options->to_stdout && markcnt > 0) { - for (i = 0; i < filecnt; i++) { + for (i = 0; i < (unsigned int)filecnt; i++) { if (files[i].flags & FF_MARK) printf("%s%c", files[i].name, options->using_null ? '\0' : '\n'); } @@ -319,7 +319,7 @@ bool ci_drag(arg_t drag_mode) float px, py; XEvent e; - if ((int)(img.w * img.zoom) <= win.w && (int)(img.h * img.zoom) <= win.h) + if ((int)(img.w * img.zoom) <= (int)win.w && (int)(img.h * img.zoom) <= (int)win.h) return false; win_set_cursor(&win, drag_mode == DRAG_ABSOLUTE ? CURSOR_DRAG_ABSOLUTE : CURSOR_DRAG_RELATIVE); |