aboutsummaryrefslogtreecommitdiffstats
path: root/image.c
diff options
context:
space:
mode:
authorNRK <nrk@disroot.org>2023-07-08 09:05:57 +0200
committerNRK <nrk@disroot.org>2023-07-08 09:05:57 +0200
commitc1b36b8f0942a8ec34f97f28c8c77c84adf0c2c4 (patch)
tree015eb4ca8387c3c698896a5c36da2b7b9abdb522 /image.c
parent9b122c82fac0f27f8fbde22b818cfa8befaaf405 (diff)
downloadnsxiv-c1b36b8f0942a8ec34f97f28c8c77c84adf0c2c4.tar.zst
add some upgrade comments (#457)
these document improvements and/or removal of unnecessary code for when we will require a higher minimum version of Imlib2. all the comments have been prefixed with "UPGRADE: " for easy grepping. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/457 Reviewed-by: explosion-mental <explosion-mental@noreply.codeberg.org>
Diffstat (limited to 'image.c')
-rw-r--r--image.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/image.c b/image.c
index e7e4455..e8fc2a9 100644
--- a/image.c
+++ b/image.c
@@ -563,6 +563,8 @@ Imlib_Image img_open(const fileinfo_t *file)
{
imlib_context_set_image(im);
}
+ /* UPGRADE: Imlib2 v1.10.0: better error reporting with
+ * imlib_get_error() + imlib_strerror() */
if (im == NULL && (file->flags & FF_WARN))
error(0, 0, "%s: Error opening image", file->name);
return im;
@@ -581,6 +583,7 @@ bool img_load(img_t *img, const fileinfo_t *file)
*/
imlib_image_set_changes_on_disk();
+/* UPGRADE: Imlib2 v1.7.5: remove these exif related ifdefs */
/* since v1.7.5, Imlib2 can parse exif orientation from jpeg files.
* this version also happens to be the first one which defines the
* IMLIB2_VERSION macro.