aboutsummaryrefslogtreecommitdiffstats
path: root/thumbs.c
diff options
context:
space:
mode:
authorNRK <nrk@disroot.org>2022-06-22 05:05:03 +0200
committerNRK <nrk@disroot.org>2022-06-22 05:05:03 +0200
commit9812d601c16fb243aac788abfeb9ea01a7870466 (patch)
tree815c5237a5790304dac29a7978932f834a3ffdb7 /thumbs.c
parenta67665a1c1569cdc16366cf635f76eb00c96048a (diff)
downloadnsxiv-9812d601c16fb243aac788abfeb9ea01a7870466.tar.zst
r_mkdir: don't truncate the path on error (#322)
currently, in case of error, r_mkdir will leave the path at a truncated state. a7d39b0ab8 is the commit that introduced this change, and in it the error printing is moved from r_mkdir to the caller, which makes me think it was probably intentional. make it so that the function itself prints the error/warning message and returns the path back to the caller unharmed. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/322 Reviewed-by: Berke Kocaoğlu <berke.kocaoglu@metu.edu.tr> Reviewed-by: TAAPArthur <taaparthur@noreply.codeberg.org>
Diffstat (limited to 'thumbs.c')
-rw-r--r--thumbs.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/thumbs.c b/thumbs.c
index 8ca0c58..d6b97ea 100644
--- a/thumbs.c
+++ b/thumbs.c
@@ -92,10 +92,8 @@ static void tns_cache_write(Imlib_Image im, const char *filepath, bool force)
{
if ((dirend = strrchr(cfile, '/')) != NULL) {
*dirend = '\0';
- if (r_mkdir(cfile) == -1) {
- error(0, errno, "%s", cfile);
+ if (r_mkdir(cfile) < 0)
goto end;
- }
*dirend = '/';
}
imlib_context_set_image(im);