[ci]: slience some clang-tidy warnings

the warnings on r_readdir(), img_load_gif() and strcpy seems to be false
positives. the warning about fmt being unused is valid, but not worth
fixing with additional #ifdef guards.

use `assert` to silence the false positive cases when possible,
otherwise use a NOLINT comment with an explanation.

1 files changed, 2 insertions, 0 deletions

diff --git a/util.c b/util.c
index 48bf61e..9c97dda 100644
--- a/util.c
+++ b/util.c
@@ -19,6 +19,7 @@
 
 #include "nsxiv.h"
 
+#include <assert.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/types.h>
@@ -178,6 +179,7 @@ char* r_readdir(r_dir_t *rdir, bool skip_dotfiles)
 
 		if (rdir->recursive && rdir->stlen > 0) {
 			/* open next subdirectory */
+			assert(rdir->dir != NULL);
 			closedir(rdir->dir);
 			if (rdir->d != 0)
 				free(rdir->name);