From 3a22e6a6c5ad10e8c5cb9abb3615d2a8867d63e9 Mon Sep 17 00:00:00 2001 From: N-R-K Date: Tue, 3 May 2022 15:36:57 +0000 Subject: Declare every extern function/variable in `nsxiv.h` (#268) with a couple exceptions as they cause too many -Wshadow warnings. also moves the `extcmd_t` typedef on top for cosmetic purposes. also enable `-Wmissing-prototypes` in the ci --- .github/workflows/build.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c527de1..69fcaea 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,9 +27,10 @@ jobs: CFLAGS="-std=c99 -Wall -pedantic" # extra flags CFLAGS+=" -O3 -flto" - CFLAGS+=" -Werror -Wextra -Wshadow -Wvla -Wpointer-arith -Wstrict-prototypes" + CFLAGS+=" -Werror -Wextra -Wshadow -Wvla -Wpointer-arith" CFLAGS+=" -Wundef -Wstrict-overflow=4 -Wwrite-strings -Wunreachable-code" CFLAGS+=" -Wbad-function-cast -Wdeclaration-after-statement" + CFLAGS+=" -Wmissing-prototypes -Wstrict-prototypes" # silence CFLAGS+=" -Wno-sign-compare -Wno-unused-parameter -Wno-missing-field-initializers" echo "### GCC BUILD ###" && make clean && make -s CC=gcc CFLAGS="$CFLAGS" LDFLAGS="$CFLAGS" OPT_DEP_DEFAULT=1 @@ -55,9 +56,10 @@ jobs: CFLAGS="-std=c99 -Wall -pedantic" # extra flags CFLAGS+=" -O3 -flto" - CFLAGS+=" -Werror -Wextra -Wshadow -Wvla -Wpointer-arith -Wstrict-prototypes" + CFLAGS+=" -Werror -Wextra -Wshadow -Wvla -Wpointer-arith" CFLAGS+=" -Wundef -Wstrict-overflow=4 -Wwrite-strings -Wunreachable-code" CFLAGS+=" -Wbad-function-cast -Wdeclaration-after-statement" + CFLAGS+=" -Wmissing-prototypes -Wstrict-prototypes" # silence CFLAGS+=" -Wno-sign-compare -Wno-unused-parameter -Wno-missing-field-initializers" echo "### GCC BUILD ###" && make clean && make -s CC=gcc CFLAGS="$CFLAGS" LDFLAGS="$CFLAGS" OPT_DEP_DEFAULT=0 -- cgit v1.2.3-54-g00ecf