From 01f3cf2e4778940a82001e48cfeec767841f52c4 Mon Sep 17 00:00:00 2001 From: NRK Date: Sat, 28 Jan 2023 10:27:40 +0000 Subject: use assertions instead of ignoring bogus arguments (#406) instead of silently ignoring bogus arguments (i.e programming errors), which can make debugging harder, it's better to assert them so that they get caught faster in debug builds. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/406 Reviewed-by: explosion-mental --- window.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'window.c') diff --git a/window.c b/window.c index 136b452..6e62979 100644 --- a/window.c +++ b/window.c @@ -22,6 +22,7 @@ #include "config.h" #include "icon/data.h" +#include #include #include #include @@ -450,10 +451,10 @@ static void win_draw_bar(win_t *win) win_bar_t *l, *r; XftDraw *d; - if ((l = &win->bar.l)->buf == NULL || (r = &win->bar.r)->buf == NULL) - return; - e = &win->env; + l = &win->bar.l; + r = &win->bar.r; + assert(l->buf != NULL && r->buf != NULL); y = (win->bar.top ? 0 : win->h) + font->ascent + V_TEXT_PAD; w = win->w - 2*H_TEXT_PAD; d = XftDrawCreate(e->dpy, win->buf.pm, e->vis, e->cmap); -- cgit v1.2.3-54-g00ecf