diff options
| author | Jay Berkenbilt <jberkenbilt@users.noreply.github.com> | 2022-09-10 13:39:25 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-10 13:39:25 +0200 |
| commit | 93f176a2a035930aea76112e23e80661edc5fdd9 (patch) | |
| tree | e9db9217d39db66f75b63353e1543a83eb89aec2 | |
| parent | 8a3cdfd2af4a95d8daede45bcb36eecdcdc8f964 (diff) | |
| download | qpdf-93f176a2a035930aea76112e23e80661edc5fdd9.tar.zst | |
Documentation fix
Remove paragraph about traversal during destruction since this is still necessary with the
new implementation.
| -rw-r--r-- | manual/design.rst | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/manual/design.rst b/manual/design.rst index 08141b3a..f256d953 100644 --- a/manual/design.rst +++ b/manual/design.rst @@ -398,7 +398,7 @@ Prior to qpdf 11, the functionality of the ``QPDFValue`` and ``QPDFObject`` classes were contained in a single ``QPDFObject`` class, which served the dual purpose of being the cache entry for ``QPDF`` and being the abstract base class for all the different PDF -object types. The behavior was nearly the same, but there were a few +object types. The behavior was nearly the same, but there were some problems: - While changes to a ``QPDFObjectHandle`` through mutation were @@ -412,11 +412,6 @@ problems: replace its internal ``QPDFObject`` pointer. This added overhead to every indirect object access even if no objects were ever changed. -- When a ``QPDF`` object was destroyed, it was necessary to - recursively traverse the structure of every object in the file to - break any circular references. For complex files, this significantly - increased the cost of destroying ``QPDF`` objects. - - When a ``QPDF`` object was destroyed, any ``QPDFObjectHandle`` objects that referenced it would maintain a potentially invalid pointer as the owning ``QPDF``. In practice, this wasn't usually a @@ -426,8 +421,8 @@ problems: software to do its own bookkeeping to ensure that an object's owner was still valid. -All of these problems were effectively solved by splitting -``QPDFObject`` into ``QPDFObject`` and ``QPDFValue``. +These problems were solved by splitting ``QPDFObject`` into +``QPDFObject`` and ``QPDFValue``. .. _casting: |