aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-09-12 19:13:33 +0200
committerJay Berkenbilt <ejb@ql.org>2022-09-12 19:19:07 +0200
commitd780954bb31dbf98af2ed61a00e22cf7680dd42c (patch)
treec01a7308f149a224a136d58fa16e93694ddb02d9
parent416d9668ee97c54a692d9280364746ce8aeeed43 (diff)
downloadqpdf-d780954bb31dbf98af2ed61a00e22cf7680dd42c.tar.zst
Add some missing QPDF_DLL markers
These markers are being added for nested classes that are already marked with QPDF_DLL_CLASS. They don't make any different on Linux, but they matter on Windows.
-rw-r--r--ChangeLog2
-rw-r--r--include/qpdf/InputSource.hh2
-rw-r--r--include/qpdf/Pl_DCT.hh2
-rw-r--r--include/qpdf/QPDFWriter.hh4
-rw-r--r--manual/release-notes.rst3
5 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index e9ae4dc8..add878fb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
2022-09-12 Jay Berkenbilt <ejb@ql.org>
+ * Add some missing DLL exports that only affect the Windows build.
+
* Remove compile-time test for LL_FMT. It's unlikely that any
compiler new enough to build qpdf still doesn't support %lld.
diff --git a/include/qpdf/InputSource.hh b/include/qpdf/InputSource.hh
index e9d99cdb..56a3782a 100644
--- a/include/qpdf/InputSource.hh
+++ b/include/qpdf/InputSource.hh
@@ -47,7 +47,9 @@ class QPDF_DLL_CLASS InputSource
class QPDF_DLL_CLASS Finder
{
public:
+ QPDF_DLL
Finder() = default;
+ QPDF_DLL
virtual ~Finder() = default;
virtual bool check() = 0;
};
diff --git a/include/qpdf/Pl_DCT.hh b/include/qpdf/Pl_DCT.hh
index fcbf1c29..3916204f 100644
--- a/include/qpdf/Pl_DCT.hh
+++ b/include/qpdf/Pl_DCT.hh
@@ -41,7 +41,9 @@ class QPDF_DLL_CLASS Pl_DCT: public Pipeline
class QPDF_DLL_CLASS CompressConfig
{
public:
+ QPDF_DLL
CompressConfig() = default;
+ QPDF_DLL
virtual ~CompressConfig() = default;
virtual void apply(jpeg_compress_struct*) = 0;
};
diff --git a/include/qpdf/QPDFWriter.hh b/include/qpdf/QPDFWriter.hh
index 245e11f3..8c076bbd 100644
--- a/include/qpdf/QPDFWriter.hh
+++ b/include/qpdf/QPDFWriter.hh
@@ -81,6 +81,7 @@ class QPDFWriter
class QPDF_DLL_CLASS ProgressReporter
{
public:
+ QPDF_DLL
virtual ~ProgressReporter();
// This method is called with a value from 0 to 100 to
@@ -95,8 +96,11 @@ class QPDFWriter
class QPDF_DLL_CLASS FunctionProgressReporter: public ProgressReporter
{
public:
+ QPDF_DLL
FunctionProgressReporter(std::function<void(int)>);
+ QPDF_DLL
virtual ~FunctionProgressReporter();
+ QPDF_DLL
virtual void reportProgress(int) override;
private:
diff --git a/manual/release-notes.rst b/manual/release-notes.rst
index e69a126e..30faf129 100644
--- a/manual/release-notes.rst
+++ b/manual/release-notes.rst
@@ -14,6 +14,9 @@ For a detailed list of changes, please see the file
- Remove ``LL_FMT`` tests, which were broken for cross
compilation. The code just uses ``%lld`` now.
+ - Some symbols were not properly exported for the Windows DLL
+ build.
+
11.0.0: September 10, 2022
- Replacement of ``PointerHolder`` with ``std::shared_ptr``