diff options
author | Jay Berkenbilt <ejb@ql.org> | 2019-06-22 00:41:42 +0200 |
---|---|---|
committer | Jay Berkenbilt <ejb@ql.org> | 2019-06-22 04:29:31 +0200 |
commit | 25dd3c67501663353ecdd881bb4322458466cbc0 (patch) | |
tree | 15713597cbd6c4b1fea70fb5dabaa38fce015bee | |
parent | c6cfd6450334cc09d3a984d710e3fcc26b809f0f (diff) | |
download | qpdf-25dd3c67501663353ecdd881bb4322458466cbc0.tar.zst |
Remove QPDF::copyForeignObject with unused parameter
-rw-r--r-- | ChangeLog | 4 | ||||
-rw-r--r-- | TODO | 3 | ||||
-rw-r--r-- | include/qpdf/QPDF.hh | 3 | ||||
-rw-r--r-- | libqpdf/QPDF.cc | 7 |
4 files changed, 4 insertions, 13 deletions
@@ -1,5 +1,9 @@ 2019-06-21 Jay Berkenbilt <ejb@ql.org> + * Source-level incompatibility: remove the version + QPDF::copyForeignObject with an unused boolean parameter. If you + were, for some reason, calling this, just take the parameter away. + * Source-level incompatibility: rename QUtil::strcasecmp to QUtil::str_compare_nocase. This is a non-compatible change, but QUtil::strcasecmp is hardly the most important part of qpdf's API. @@ -1,9 +1,6 @@ Next ABI ======== - * Get rid of the version of QPDF::copyForeignObject with the bool - unused parameter. - * Remove version of QPDFTokenizer::expectInlineImage with no arguments. diff --git a/include/qpdf/QPDF.hh b/include/qpdf/QPDF.hh index c3fa0873..f8a84ce9 100644 --- a/include/qpdf/QPDF.hh +++ b/include/qpdf/QPDF.hh @@ -934,9 +934,6 @@ class QPDF QPDFObjectHandle& stream_dict, bool is_attachment_stream, std::vector<PointerHolder<Pipeline> >& heap); - // Unused copyForeignObject -- remove at next ABI change - QPDFObjectHandle copyForeignObject( - QPDFObjectHandle foreign, bool unused); // Methods to support object copying void reserveObjects(QPDFObjectHandle foreign, ObjCopier& obj_copier, bool top); diff --git a/libqpdf/QPDF.cc b/libqpdf/QPDF.cc index 55f220d8..a549eed0 100644 --- a/libqpdf/QPDF.cc +++ b/libqpdf/QPDF.cc @@ -2142,13 +2142,6 @@ QPDF::replaceReserved(QPDFObjectHandle reserved, } QPDFObjectHandle -QPDF::copyForeignObject(QPDFObjectHandle foreign, bool) -{ - // This method will be removed next time the ABI is changed. - return copyForeignObject(foreign); -} - -QPDFObjectHandle QPDF::copyForeignObject(QPDFObjectHandle foreign) { // Do not preclude use of copyForeignObject on page objects. It is |