diff options
author | Jay Berkenbilt <ejb@ql.org> | 2017-08-29 18:27:59 +0200 |
---|---|---|
committer | Jay Berkenbilt <ejb@ql.org> | 2017-08-29 18:28:32 +0200 |
commit | 1868a10f8b06631362618bfc85ca8646da4b4b71 (patch) | |
tree | c3029002f777a9904bfa3dff559daea989c79025 /README-maintainer.md | |
parent | 742190bd98c0981a07cb39a8eae1e99d909ad5ae (diff) | |
download | qpdf-1868a10f8b06631362618bfc85ca8646da4b4b71.tar.zst |
Replace all atoi calls with QUtil::string_to_int
The latter catches underflow/overflow.
Diffstat (limited to 'README-maintainer.md')
-rw-r--r-- | README-maintainer.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/README-maintainer.md b/README-maintainer.md index 45b19d76..9aa29d38 100644 --- a/README-maintainer.md +++ b/README-maintainer.md @@ -17,6 +17,7 @@ * Test with clang. * Check all open issues in the sourceforge trackers and on github. * If any interfaces were added or changed, check C API to see whether changes are appropriate there as well. If necessary, review the casting policy in the manual, and ensure that integer types are properly handled. +* Avoid atoi. Use QUtil::string_to_int instead. It does overflow/underflow checking. * Remember to avoid using `operator[]` with `std::string` or `std::vector`. Instead, use `at()`. See README-hardening.md for details. * Increment shared library version information as needed (`LT_*` in `configure.ac`) * Update release notes in manual. Look at diffs and ChangeLog. |