aboutsummaryrefslogtreecommitdiffstats
path: root/README-maintainer.md
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2017-08-29 03:47:56 +0200
committerJay Berkenbilt <ejb@ql.org>2017-08-29 04:28:12 +0200
commitd7d446e0b8aacd122d1a000d38ebafa4dbf5b3d2 (patch)
tree87f294891e08279c361b2696fa7118f05fcab5b9 /README-maintainer.md
parentabb3191c32adb982a0a80e1b76976d34f4df3788 (diff)
downloadqpdf-d7d446e0b8aacd122d1a000d38ebafa4dbf5b3d2.tar.zst
Remove valgrind -- address santizer is better
Diffstat (limited to 'README-maintainer.md')
-rw-r--r--README-maintainer.md11
1 files changed, 2 insertions, 9 deletions
diff --git a/README-maintainer.md b/README-maintainer.md
index 08bb3d2e..45b19d76 100644
--- a/README-maintainer.md
+++ b/README-maintainer.md
@@ -13,14 +13,7 @@
LDFLAGS="-fsanitize=address" \
--enable-werror --disable-shared
```
- As of gcc 6.3.0, this exposes some good things but appears to also have some false positive leak reports. Valgrind is more reliable but also may miss some things that this catches.
-* Consider running tests with latest gcc and/or valgrind. To test with valgrind:
- ```
- ./configure --disable-shared
- make -j8 -k VALGRIND=1
- make -k check NO_REBUILD=1
- ```
- This moves each binary into a subdirectory and replaces it with a link to make/exec-z. See make/exec-z.
+ The test suite should run clean with this. This seems to be more reliable than valgrind.
* Test with clang.
* Check all open issues in the sourceforge trackers and on github.
* If any interfaces were added or changed, check C API to see whether changes are appropriate there as well. If necessary, review the casting policy in the manual, and ensure that integer types are properly handled.
@@ -83,7 +76,7 @@ If building or editing documentation, configure with `--enable-doc-maintenance`.
If you want to run `make maintainer-clean`, `make distclean`, or `make autofiles.zip` and you haven't run `./configure`, you can pass `CLEAN=1` to make on the command line to prevent it from complaining about configure not having been run.
-If you want to run checks without rerunning the build, pass `NO_REBUILD=1` to make. This can be useful for special testing scenarios such as valgrind or binary compatibility.
+If you want to run checks without rerunning the build, pass `NO_REBUILD=1` to make. This can be useful for special testing scenarios such as validation of memory fixes or binary compatibility.
# Local Windows Testing Procedure