aboutsummaryrefslogtreecommitdiffstats
path: root/README-maintainer
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-07-31 14:19:03 +0200
committerJay Berkenbilt <ejb@ql.org>2022-07-31 14:21:53 +0200
commitc9cc8cfd74fdb59d5450939e1772dea35d369b04 (patch)
tree4c049a59e612437635b80d31d4db9bc0ac40d9bb /README-maintainer
parent4674c04cb80e0a50cde1b97464642e2778f9522f (diff)
downloadqpdf-c9cc8cfd74fdb59d5450939e1772dea35d369b04.tar.zst
Remove lgtm banner
Over time, qpdf's grade has dropped on lgtm, but they are not transparent about how grades are assigned. Fixing current alerts, in my opinion, reduces clarity and maintainability of the code in the name of performance in non-critical sections of code. Some analysis by m-holger suggests that fixing some of the current alerts actually degrades performance (slightly) while fixing others results in insignificant improvements. The quality of qpdf can be measured in other ways, such as its extensive test suite, documentation, and long track record of reliably manipulating PDFs with high performance, few bugs, and few external dependencies. The lgtm rating is a distraction at best.
Diffstat (limited to 'README-maintainer')
-rw-r--r--README-maintainer3
1 files changed, 2 insertions, 1 deletions
diff --git a/README-maintainer b/README-maintainer
index 29291634..c2967c99 100644
--- a/README-maintainer
+++ b/README-maintainer
@@ -291,7 +291,8 @@ RELEASE PREPARATION
* Check for open fuzz crashes at https://oss-fuzz.com
-* Check lgtm: https://lgtm.com/projects/g/qpdf/qpdf/?mode=list
+* Check lgtm: https://lgtm.com/projects/g/qpdf/qpdf/?mode=list for
+ anything worth fixing
* Check all open issues and pull requests in github and the
sourceforge trackers. See ~/scripts/github-issues. Don't forget pull