diff options
author | Jay Berkenbilt <ejb@ql.org> | 2022-09-08 14:03:57 +0200 |
---|---|---|
committer | Jay Berkenbilt <ejb@ql.org> | 2022-09-08 16:36:39 +0200 |
commit | dba61da1bfb7e4d74c723f369d1c017df9707a14 (patch) | |
tree | 04c51f86dc066c710c23423fe178e051b20b49d9 /TODO | |
parent | 264e25f391f83bcbeb60590f18ff96719b086454 (diff) | |
download | qpdf-dba61da1bfb7e4d74c723f369d1c017df9707a14.tar.zst |
Create a special "destroyed" type rather than using null
When a QPDF is destroyed, changing indirect objects to direct nulls
makes them effectively disappear silently when they sneak into other
places. Instead, we should treat this as an error. Adding a destroyed
object type makes this possible.
Diffstat (limited to 'TODO')
-rw-r--r-- | TODO | 14 |
1 files changed, 8 insertions, 6 deletions
@@ -812,9 +812,11 @@ Rejected Ideas QPDFObjectHandle because of indirect objects. This only pertains to direct objects, which are always "resolved" in QPDFObjectHandle. - If this is addressed, read comments in QPDFWriter.cc::enqueueObject - near the call to getOwningQPDF, comments in QPDFValueProxy::reset, - and comments in QPDF::~QPDF() near the line that assigns to null. - This will also affect test 92 in test_driver.cc. All these - references were from the release of qpdf 11 (in case they have moved - by such time as this might be resurrected). + If this is addressed, read comments in the following places: + * QPDFWriter.cc::enqueueObject near the call to getOwningQPDF + * QPDFValueProxy::reset and QPDFValueProxy::destroy + * QPDF::~QPDF() + * test 92 in test_driver.cc + * QPDFObjectHandle.hh near isDestroyed + All these references were from the release of qpdf 11 (in case they + have moved by such time as this might be resurrected). |