Bug fix: avoid extraneous pipeline finish calls with multiple contents

Avoid calling finish() multiple times on the pipeline passed to
pipeContentStreams. This commit also fixes a bug in which qpdf was not
exiting with the proper exit status if warnings found while splitting
pages; this was exposed by a test case that changed.

1 files changed, 0 insertions, 17 deletions

diff --git a/TODO b/TODO
index 857fb701..0cf8017d 100644
--- a/TODO
+++ b/TODO
@@ -16,23 +16,6 @@ Candidates for upcoming release
     definition of an object without breaking compatibility
   * See if the objects part can be sorted by object number
 
-* QPDFObjectHandle::pipeContentStreams calls finish() after each
-  stream. In some code paths, Pl_Concatenate is used, which suppresses
-  that, but in other code paths, it's not used, and the library relies
-  on the behavior of finish() being called. Then there's the issue of
-  nested Pl_Concatenate pipelines -- calling manualFinish() on the top
-  one doesn't call manualFinish() on the lower ones, and there are no
-  exposed methods that allow us to apply things down the pipeline
-  stack, so it's hard to fix this without changing the API (at least
-  making Pipeline::getNext() public, which may be undesirable). To see
-  this problem in action, stick a Pl_Concatenate in front of the
-  pipeline in pipeContentStreams and observe the test failure. One
-  solution might be to add an additional argument indicating whether
-  or not to delay calling finish() until the end. See comments on
-  QPDFPageObjectHelper::filterPageContents,
-  QPDFObjectHandle::filterPageContents, and
-  QPDFObjectHandle::pipeContentStreams
-
 * Remember to check work `qpdf` project for private issues
   * file with very slow page extraction
   * big page even with --remove-unreferenced-resources=yes, even with --empty