Convert remaining public classes to use Members pattern

Have classes contain only a single private member of type
PointerHolder<Members>. This makes it safe to change the structure of
the Members class without breaking binary compatibility. Many of the
classes already follow this pattern quite successfully. This brings in
the rest of the class that are part of the public API.

1 files changed, 17 insertions, 4 deletions

diff --git a/include/qpdf/FileInputSource.hh b/include/qpdf/FileInputSource.hh
index 0845f241..1bf2a2de 100644
--- a/include/qpdf/FileInputSource.hh
+++ b/include/qpdf/FileInputSource.hh
@@ -54,11 +54,24 @@ class FileInputSource: public InputSource
     FileInputSource(FileInputSource const&);
     FileInputSource& operator=(FileInputSource const&);
 
-    void destroy();
+    class Members
+    {
+        friend class FileInputSource;
 
-    bool close_file;
-    std::string filename;
-    FILE* file;
+      public:
+        QPDF_DLL
+        ~Members();
+
+      private:
+        Members(bool close_file);
+        Members(Members const&);
+
+        bool close_file;
+        std::string filename;
+        FILE* file;
+    };
+
+    PointerHolder<Members> m;
 };
 
 #endif // QPDF_FILEINPUTSOURCE_HH