aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-02-08 22:48:13 +0100
committerJay Berkenbilt <ejb@ql.org>2022-02-08 22:49:43 +0100
commitec778ef98b0b20e2bf4592b00d0a6ac39b69c511 (patch)
tree370f2beb6784c776791fb14a9e5476f0413da1bb /include
parentfa0b63846b5bf359539053b4da52997cd6b9eadf (diff)
downloadqpdf-ec778ef98b0b20e2bf4592b00d0a6ac39b69c511.tar.zst
Add additional comments about new accessor methods
Diffstat (limited to 'include')
-rw-r--r--include/qpdf/QPDFObjectHandle.hh26
1 files changed, 19 insertions, 7 deletions
diff --git a/include/qpdf/QPDFObjectHandle.hh b/include/qpdf/QPDFObjectHandle.hh
index 359c9e19..e536c3cc 100644
--- a/include/qpdf/QPDFObjectHandle.hh
+++ b/include/qpdf/QPDFObjectHandle.hh
@@ -657,13 +657,25 @@ class QPDFObjectHandle
//
// In PDF files, objects have specific types, but there is nothing
// that prevents PDF files from containing objects of types that
- // aren't expected by the specification. Many of the accessors
- // here expect objects of a particular type. Prior to qpdf 8,
- // calling an accessor on a method of the wrong type, such as
- // trying to get a dictionary key from an array, trying to get the
- // string value of a number, etc., would throw an exception, but
- // since qpdf 8, qpdf issues a warning and recovers using the
- // following behavior:
+ // aren't expected by the specification.
+ //
+ // There are two flavors of accessor methods:
+ //
+ // * getSomethingValue() returns the value and issues a type
+ // warning if the type is incorrect.
+ //
+ // * getValueAsSomething() returns false if the value is the wrong
+ // type. Otherwise, it returns true and initializes a reference
+ // of the appropriate type. These methods never issue type
+ // warnings.
+ //
+ // The getSomethingValue() accessors and some of the other methods
+ // expect objects of a particular type. Prior to qpdf 8, calling
+ // an accessor on a method of the wrong type, such as trying to
+ // get a dictionary key from an array, trying to get the string
+ // value of a number, etc., would throw an exception, but since
+ // qpdf 8, qpdf issues a warning and recovers using the following
+ // behavior:
//
// * Requesting a value of the wrong type (int value from string,
// array item from a scalar or dictionary, etc.) will return a