diff options
author | Jay Berkenbilt <ejb@ql.org> | 2021-04-05 16:45:18 +0200 |
---|---|---|
committer | Jay Berkenbilt <ejb@ql.org> | 2021-04-05 16:58:10 +0200 |
commit | 8971443e4680fc1c0babe56da58cc9070a9dae2e (patch) | |
tree | 9a95940010bcf7e0790834621bc885492898a3c6 /include | |
parent | ec48820c3cf8ead0add464c60f5dddd84ba0097d (diff) | |
download | qpdf-8971443e4680fc1c0babe56da58cc9070a9dae2e.tar.zst |
QPDF::addPage*: handle duplicate pages more robustly
Diffstat (limited to 'include')
-rw-r--r-- | include/qpdf/QPDFPageDocumentHelper.hh | 21 |
1 files changed, 15 insertions, 6 deletions
diff --git a/include/qpdf/QPDFPageDocumentHelper.hh b/include/qpdf/QPDFPageDocumentHelper.hh index 02c039b5..867ddac0 100644 --- a/include/qpdf/QPDFPageDocumentHelper.hh +++ b/include/qpdf/QPDFPageDocumentHelper.hh @@ -73,12 +73,21 @@ class QPDFPageDocumentHelper: public QPDFDocumentHelper // indirect. If it is an indirect object from another QPDF, this // method will call pushInheritedAttributesToPage on the other // file and then copy the page to this QPDF using the same - // underlying code as copyForeignObject. Note that you can call - // copyForeignObject directly to copy a page from a different - // file, but the resulting object will not be a page in the new - // file. You could do this, for example, to convert a page into a - // form XObject, though for that, you're better off using - // QPDFPageObjectHelper::getFormXObjectForPage. + // underlying code as copyForeignObject. At this stage, if the + // indirect object is already in the pages tree, a shallow copy is + // made to avoid adding the same page more than once. In version + // 10.3.1 and earlier, adding a page that already existed would + // throw an exception and could cause qpdf to crash on subsequent + // page insertions in some cases. Note that this means that, in + // some cases, the page actually added won't be exactly the same + // object as the one passed in. If you want to do subsequent + // modification on the page, you should retrieve it again. + // + // Note that you can call copyForeignObject directly to copy a + // page from a different file, but the resulting object will not + // be a page in the new file. You could do this, for example, to + // convert a page into a form XObject, though for that, you're + // better off using QPDFPageObjectHelper::getFormXObjectForPage. // // This method does not have any specific awareness of annotations // or form fields, so if you just add a page without thinking |