aboutsummaryrefslogtreecommitdiffstats
path: root/libqpdf/ClosedFileInputSource.cc
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2018-08-12 18:58:39 +0200
committerJay Berkenbilt <ejb@ql.org>2018-08-12 18:58:39 +0200
commitb6e414b10b3ae7b28ad16da2027106ec59a99a0a (patch)
treececd3bb38d43af6d4fa687414d2565e71c0ac206 /libqpdf/ClosedFileInputSource.cc
parent4a4736c6954ab17d923a6d2968f34a33e09d714f (diff)
downloadqpdf-b6e414b10b3ae7b28ad16da2027106ec59a99a0a.tar.zst
Remove some extraneous null pointer checks (fixes #234)
There were a few places in the code that were checking that a pointer wasn't null before deleting it, even though C++ has always allowed delete 0. Most of the code did not perform these checks.
Diffstat (limited to 'libqpdf/ClosedFileInputSource.cc')
-rw-r--r--libqpdf/ClosedFileInputSource.cc5
1 files changed, 1 insertions, 4 deletions
diff --git a/libqpdf/ClosedFileInputSource.cc b/libqpdf/ClosedFileInputSource.cc
index 63357886..e9c9b3bd 100644
--- a/libqpdf/ClosedFileInputSource.cc
+++ b/libqpdf/ClosedFileInputSource.cc
@@ -11,10 +11,7 @@ ClosedFileInputSource::Members::Members(char const* filename) :
ClosedFileInputSource::Members::~Members()
{
- if (fis)
- {
- delete fis;
- }
+ delete fis;
}
ClosedFileInputSource::ClosedFileInputSource(char const* filename) :