enhance PointerHolder so that it can explicitly be told to use delete [] instead of delete, thus making it useful to run valgrind over qpdf during its test suite

1 files changed, 3 insertions, 4 deletions

diff --git a/libqpdf/QPDF.cc b/libqpdf/QPDF.cc
index d614efe5..d161aebc 100644
--- a/libqpdf/QPDF.cc
+++ b/libqpdf/QPDF.cc
@@ -403,10 +403,9 @@ QPDF::parse(char const* password)
 	this->file->rewind();
     }
     char* buf = new char[tbuf_size + 1];
-    // Put buf in a PointerHolder to guarantee deletion of buf.  This
-    // calls delete rather than delete [], but it's okay since buf is
-    // an array of fundamental types.
-    PointerHolder<char> b(buf);
+    // Put buf in an array-style PointerHolder to guarantee deletion
+    // of buf.
+    PointerHolder<char> b(true, buf);
     memset(buf, '\0', tbuf_size + 1);
     this->file->read(buf, tbuf_size);