aboutsummaryrefslogtreecommitdiffstats
path: root/libqpdf/QPDFJob.cc
diff options
context:
space:
mode:
authorm-holger <m-holger@kubitscheck.org>2022-06-23 11:32:32 +0200
committerJay Berkenbilt <jberkenbilt@users.noreply.github.com>2022-06-25 14:24:50 +0200
commit97f737a562dcf7f50cec2060c9cc5a9dce06f58f (patch)
tree0a7db427964b135799e1e5e0c228d42027b5c3ab /libqpdf/QPDFJob.cc
parent1eb2f208ecfffd44c934f7ff3fa42189c206541d (diff)
downloadqpdf-97f737a562dcf7f50cec2060c9cc5a9dce06f58f.tar.zst
Code tidy: QPDFJob::doJSONPageLabels
Remove redundant variables pages and next.
Diffstat (limited to 'libqpdf/QPDFJob.cc')
-rw-r--r--libqpdf/QPDFJob.cc11
1 files changed, 4 insertions, 7 deletions
diff --git a/libqpdf/QPDFJob.cc b/libqpdf/QPDFJob.cc
index 5631df49..7227bd1b 100644
--- a/libqpdf/QPDFJob.cc
+++ b/libqpdf/QPDFJob.cc
@@ -1239,16 +1239,13 @@ QPDFJob::doJSONPageLabels(Pipeline* p, bool& first, QPDF& pdf)
{
JSON j_labels = JSON::makeArray();
QPDFPageLabelDocumentHelper pldh(pdf);
- QPDFPageDocumentHelper pdh(pdf);
- std::vector<QPDFPageObjectHelper> pages = pdh.getAllPages();
+ long long npages = QIntC::to_longlong(
+ QPDFPageDocumentHelper(pdf).getAllPages().size());
if (pldh.hasPageLabels()) {
std::vector<QPDFObjectHandle> labels;
- pldh.getLabelsForPageRange(
- 0, QIntC::to_int(pages.size()) - 1, 0, labels);
+ pldh.getLabelsForPageRange(0, npages - 1, 0, labels);
for (auto iter = labels.begin(); iter != labels.end(); ++iter) {
- auto next = iter;
- ++next;
- if (next == labels.end()) {
+ if ((iter + 1) == labels.end()) {
// This can't happen, so ignore it. This could only
// happen if getLabelsForPageRange somehow returned an
// odd number of items.