QPDFJob: allocate QPDFArgParser on stack

The previous commits have removed all references to memory from
QPDFArgParser from QPDFJob. This commit removes the constraint that
QPDFArgParser remain in scope. This is a prerequisite to allowing JSON
as an alternative way to initialize QPDFJob and to initialize it
directly using a public API.

1 files changed, 3 insertions, 6 deletions

diff --git a/libqpdf/QPDFJob_argv.cc b/libqpdf/QPDFJob_argv.cc
index 316beda0..8da5e836 100644
--- a/libqpdf/QPDFJob_argv.cc
+++ b/libqpdf/QPDFJob_argv.cc
@@ -1529,11 +1529,8 @@ QPDFJob::initializeFromArgv(int argc, char* argv[], char const* progname_env)
     {
         progname_env = "QPDF_EXECUTABLE";
     }
-    // QPDFArgParser must stay in scope for the life of the QPDFJob
-    // object since it holds dynamic memory used for argv, which is
-    // pointed to by other member variables.
-    this->m->ap = std::make_shared<QPDFArgParser>(argc, argv, progname_env);
-    setMessagePrefix(this->m->ap->getProgname());
-    ArgParser ap(*this->m->ap, *this);
+    QPDFArgParser qap(argc, argv, progname_env);
+    setMessagePrefix(qap.getProgname());
+    ArgParser ap(qap, *this);
     ap.parseOptions();
 }