aboutsummaryrefslogtreecommitdiffstats
path: root/libqpdf/QPDFObjectHandle.cc
diff options
context:
space:
mode:
authorm-holger <m-holger@kubitscheck.org>2022-12-10 20:48:07 +0100
committerm-holger <m-holger@kubitscheck.org>2023-04-01 14:56:10 +0200
commit1bb23d0545dfe2d651cb22b6135d99c1c9ef85d5 (patch)
tree8d9a96312225de8fa70d768bf5f6249e779fbe22 /libqpdf/QPDFObjectHandle.cc
parentcedb37caa153abfd92a91b2e39a6f32601be826c (diff)
downloadqpdf-1bb23d0545dfe2d651cb22b6135d99c1c9ef85d5.tar.zst
Refactor QPDF_Array::insertItem and rename to insert
Diffstat (limited to 'libqpdf/QPDFObjectHandle.cc')
-rw-r--r--libqpdf/QPDFObjectHandle.cc9
1 files changed, 6 insertions, 3 deletions
diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc
index 0c4d45ae..fa8b9136 100644
--- a/libqpdf/QPDFObjectHandle.cc
+++ b/libqpdf/QPDFObjectHandle.cc
@@ -932,9 +932,12 @@ QPDFObjectHandle::setArrayFromVector(std::vector<QPDFObjectHandle> const& items)
void
QPDFObjectHandle::insertItem(int at, QPDFObjectHandle const& item)
{
- auto array = asArray();
- if (array) {
- array->insertItem(at, item);
+ if (auto array = asArray()) {
+ if (!array->insert(at, item)) {
+ objectWarning(
+ "ignoring attempt to insert out of bounds array item");
+ QTC::TC("qpdf", "QPDFObjectHandle insert array bounds");
+ }
} else {
typeWarning("array", "ignoring attempt to insert item");
QTC::TC("qpdf", "QPDFObjectHandle array ignoring insert item");