Remove unnecessary string copy in QPDFTokenizer::getToken

1 files changed, 5 insertions, 6 deletions

diff --git a/libqpdf/QPDFTokenizer.cc b/libqpdf/QPDFTokenizer.cc
index 07f6bfb7..6e492f2b 100644
--- a/libqpdf/QPDFTokenizer.cc
+++ b/libqpdf/QPDFTokenizer.cc
@@ -951,12 +951,11 @@ QPDFTokenizer::getToken(Token& token, bool& unread_char, char& ch)
     unread_char = !this->in_token && !this->before_token;
     ch = this->char_to_unread;
     if (ready) {
-        if (this->type == tt_bad) {
-            this->val.clear();
-            this->val += this->raw_val;
-        }
-        token =
-            Token(this->type, this->val, this->raw_val, this->error_message);
+        token = (this->type == tt_bad)
+            ? Token(
+                  this->type, this->raw_val, this->raw_val, this->error_message)
+            : Token(this->type, this->val, this->raw_val, this->error_message);
+
         this->reset();
     }
     return ready;