QPDFWriter: clean up overloaded functions

In a small number of cases, it makes sense to replace an overloaded
function with a function that takes a default argument. We can do this
now because we've already broken binary compatibility since the last
release.

1 files changed, 6 insertions, 18 deletions

diff --git a/libqpdf/QPDFWriter.cc b/libqpdf/QPDFWriter.cc
index 93a634f2..7702dc34 100644
--- a/libqpdf/QPDFWriter.cc
+++ b/libqpdf/QPDFWriter.cc
@@ -232,12 +232,6 @@ QPDFWriter::setNewlineBeforeEndstream(bool val)
 }
 
 void
-QPDFWriter::setMinimumPDFVersion(std::string const& version)
-{
-    setMinimumPDFVersion(version, 0);
-}
-
-void
 QPDFWriter::setMinimumPDFVersion(std::string const& version,
                                  int extension_level)
 {
@@ -286,12 +280,6 @@ QPDFWriter::setMinimumPDFVersion(std::string const& version,
 }
 
 void
-QPDFWriter::forcePDFVersion(std::string const& version)
-{
-    forcePDFVersion(version, 0);
-}
-
-void
 QPDFWriter::forcePDFVersion(std::string const& version,
                             int extension_level)
 {
@@ -1434,12 +1422,6 @@ QPDFWriter::writeTrailer(trailer_e which, int size, bool xref_stream,
 }
 
 void
-QPDFWriter::unparseObject(QPDFObjectHandle object, int level, int flags)
-{
-    unparseObject(object, level, flags, 0, false);
-}
-
-void
 QPDFWriter::unparseObject(QPDFObjectHandle object, int level,
 			  int flags, size_t stream_length,
                           bool compress)
@@ -2811,6 +2793,9 @@ QPDFWriter::writeHintStream(int hint_id)
 qpdf_offset_t
 QPDFWriter::writeXRefTable(trailer_e which, int first, int last, int size)
 {
+    // There are too many extra arguments to replace overloaded
+    // function with defaults in the header file...too much risk of
+    // leaving something off.
     return writeXRefTable(which, first, last, size, 0, false, 0, 0, 0, 0);
 }
 
@@ -2858,6 +2843,9 @@ qpdf_offset_t
 QPDFWriter::writeXRefStream(int objid, int max_id, qpdf_offset_t max_offset,
 			    trailer_e which, int first, int last, int size)
 {
+    // There are too many extra arguments to replace overloaded
+    // function with defaults in the header file...too much risk of
+    // leaving something off.
     return writeXRefStream(objid, max_id, max_offset,
 			   which, first, last, size, 0, 0, 0, 0, false, 0);
 }