QTC: cache get_env results for improved performance

It turns out that QUtil::get_env is particularly expensive on Windows
if there is a large environment. This may be true on other platforms
as well.

1 files changed, 10 insertions, 2 deletions

diff --git a/libqpdf/QTC.cc b/libqpdf/QTC.cc
index d27bfa8b..21d240ba 100644
--- a/libqpdf/QTC.cc
+++ b/libqpdf/QTC.cc
@@ -2,6 +2,7 @@
 
 #include <qpdf/QUtil.hh>
 #include <set>
+#include <map>
 #include <stdio.h>
 
 static bool
@@ -14,12 +15,19 @@ tc_active(char const* const scope)
 void
 QTC::TC(char const* const scope, char const* const ccase, int n)
 {
-    static std::set<std::pair<std::string, int>> cache;
+    static std::map<std::string, bool> active;
+    auto is_active = active.find(scope);
+    if (is_active == active.end()) {
+        active[scope] = tc_active(scope);
+        is_active = active.find(scope);
+    }
 
-    if (!tc_active(scope)) {
+    if (!is_active->second) {
         return;
     }
 
+    static std::set<std::pair<std::string, int>> cache;
+
     std::string filename;
 #ifdef _WIN32
 # define TC_ENV "TC_WIN_FILENAME"