Take advantage of unique_ptr and move construction for Buffer

Since Buffer has always implemented its copy constructor with a deep
copy, its Members object will never have multiple owners. Change to unique_ptr.

Also implement move constructors for Buffer, since there may be cases
where a deep copy is not needed.

1 files changed, 17 insertions, 0 deletions

diff --git a/libtests/buffer.cc b/libtests/buffer.cc
index a65efb1c..f372e7b4 100644
--- a/libtests/buffer.cc
+++ b/libtests/buffer.cc
@@ -37,6 +37,23 @@ main()
         assert(bc2p[1] == 'W');
     }
 
+    {
+        // Test that buffers can be moved.
+        Buffer bm1(2);
+        unsigned char* bm1p = bm1.getBuffer();
+        bm1p[0] = 'Q';
+        bm1p[1] = 'W';
+        Buffer bm2(std::move(bm1));
+        bm1p[0] = 'R';
+        unsigned char* bm2p = bm2.getBuffer();
+        assert(bm2p == bm1p);
+        assert(bm2p[0] == 'R');
+
+        Buffer bm3 = std::move(bm2);
+        unsigned char* bm3p = bm3.getBuffer();
+        assert(bm3p == bm2p);
+    }
+
     try {
         Pl_Discard discard;
         Pl_Count count("count", &discard);