aboutsummaryrefslogtreecommitdiffstats
path: root/qpdf
diff options
context:
space:
mode:
authorJay Berkenbilt <ejb@ql.org>2022-09-08 17:06:15 +0200
committerJay Berkenbilt <ejb@ql.org>2022-09-08 17:06:15 +0200
commitc7a4967d10fb9688f235baa8e57a1fb578f5387d (patch)
treeb14956a2371befbd30b2a43583c390bc170ccd3d /qpdf
parentdba61da1bfb7e4d74c723f369d1c017df9707a14 (diff)
downloadqpdf-c7a4967d10fb9688f235baa8e57a1fb578f5387d.tar.zst
Change reset to disconnect and clarify comments
I decided that it's actually fine to copy a direct object to another QPDF. Even if we eventually prevent a QPDFObject from having multiple parents, this could happen if an object is moved.
Diffstat (limited to 'qpdf')
-rw-r--r--qpdf/test_driver.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/qpdf/test_driver.cc b/qpdf/test_driver.cc
index 96d001d6..3e74c106 100644
--- a/qpdf/test_driver.cc
+++ b/qpdf/test_driver.cc
@@ -3316,8 +3316,8 @@ test_92(QPDF& pdf, char const* arg2)
check(contents);
check(contents_dict);
// Objects that were originally indirect should be destroyed.
- // Otherwise, they should have retained their old values. See
- // comments in QPDFValueProxy::reset for why this is the case.
+ // Otherwise, they should have retained their old values but just
+ // lost their connection to the owning QPDF.
assert(root.isDestroyed());
assert(page1.isDestroyed());
assert(contents.isDestroyed());