Age | Commit message (Collapse) | Author |
|
|
|
This reverts commit dc059560e73e0b373a6e54e71b07e3af4b692cb4.
I changed my mind. There's no harm in leaving it deprecated for a
release cycle.
|
|
See ChangeLog for rationale for not deprecating it as originally
planned.
|
|
Where not possible, use "auto" to get the iterator type.
Editorial note: I have avoid this change for a long time because of
not wanting to make gratuitous changes to version history, which can
obscure when certain changes were made, but with having recently
touched every single file to apply automatic code formatting and with
making several broad changes to the API, I decided it was time to take
the plunge and get rid of the older (pre-C++11) verbose iterator
syntax. The new code is just easier to read and understand, and in
many cases, it will be more effecient as fewer temporary copies are
being made.
m-holger, if you're reading, you can see that I've finally come
around. :-)
|
|
Change .clang-format and commit automated changes from a fresh run of
format-code
|
|
|
|
|
|
|
|
|
|
|
|
It was being run at configuration time, not build time.
|
|
Make it so that a key with a null value is always treated as not being
present. This was inconsistent before.
|
|
|
|
|
|
|
|
|
|
Character transcoding from Unicode to single-byte characters used
hard-coded switch statements because the code predated our adoption of
C++11. Now we have thread-safe, static initialization of map literals,
so use that instead.
|
|
|
|
|
|
Remove the name/number tree object helper constructors that don't take
a QPDF&.
|
|
|
|
|
|
|
|
* Merge overloaded functions by adding default values
* Remove non-const methods that are identical to const methods
|
|
|
|
* Change DLL_EXPORT to libqpdf_EXPORTS (internal to the build). The
new name is cmake's default, is more conventional, and is less
likely to clash with other symbols.
* Add QPDF_DLL_PRIVATE for non-Windows
* Make logic around when to define QPDF_DLL et al more explicit
* Add detailed comments
|
|
Prior to the cmake conversion, several private classes had methods
that were exported into the shared library so they could be tested
with libtests. With cmake, we build libtests using an object library,
so this is no longer necessary. The methods that are disappearing from
the ABI were never exposed through public headers, so no code should
be using them. Removal had to wait until the window for ABI-breaking
changes was open.
|
|
Increase to POINTERHOLDER_TRANSITION=4
|
|
(patrepl and cleanpatch are my own utilities)
patrepl s/PointerHolder/std::shared_ptr/g {include,libqpdf}/qpdf/*.hh
patrepl s/PointerHolder/std::shared_ptr/g libqpdf/*.cc
patrepl s/make_pointer_holder/std::make_shared/g libqpdf/*.cc
patrepl s/make_array_pointer_holder/QUtil::make_shared_array/g libqpdf/*.cc
patrepl s,qpdf/std::shared_ptr,qpdf/PointerHolder, **/*.cc **/*.hh
git restore include/qpdf/PointerHolder.hh
cleanpatch
./format-code
|
|
|
|
|
|
Add comments to force line breaks, parenthesize function arguments
that are contatenated strings, etc. -- these kinds of changes improve
clang-format's results and also cause emacs cc-mode to match
clang-format. After this type of change, most of the time, when
clang-format and emacs disagree, clang-format is better.
|
|
Run this:
for i in **/*.cc **/*.c **/*.h **/*.hh; do
clang-format < $i >| $i.new && mv $i.new $i
done
|
|
|
|
|
|
Also add a pkg-config runtime test that would have caught the error.
|
|
Some platforms need it for atomic<long long> but not for atomic<int>.
|
|
The executables that libtool built invoked the underlying binary with
an "lt-" prefix. The code contained numerous workarounds for testing,
which can now be removed.
|
|
|
|
|
|
|
|
|
|
It's better to just make it a .hh file to reduce confusion.
|
|
|
|
|
|
This is so it will fit on one line after a qtest upgrade allows us to
split lines.
|
|
|
|
This was mainly to get comments about defaults out of constructor
initializer lists where their fragile when a code formatter is being
used.
|
|
|
|
|