From 0aae54d3836107fdb9dc54faf0778bf262dd7e0a Mon Sep 17 00:00:00 2001
From: m-holger <m-holger@kubitscheck.org>
Date: Thu, 30 Mar 2023 14:16:07 +0100
Subject: Refactor QPDF_Array::setFromVector

---
 libqpdf/QPDFObjectHandle.cc |  6 +-----
 libqpdf/QPDF_Array.cc       | 45 +++++++++++++++++----------------------------
 libqpdf/qpdf/QPDF_Array.hh  |  1 -
 3 files changed, 18 insertions(+), 34 deletions(-)

diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc
index 20be3f9d..c2bc30f0 100644
--- a/libqpdf/QPDFObjectHandle.cc
+++ b/libqpdf/QPDFObjectHandle.cc
@@ -916,11 +916,7 @@ QPDFObjectHandle::setArrayItem(int n, QPDFObjectHandle const& item)
 void
 QPDFObjectHandle::setArrayFromVector(std::vector<QPDFObjectHandle> const& items)
 {
-    auto array = asArray();
-    if (array) {
-        for (auto const& item: items) {
-            checkOwnership(item);
-        }
+    if (auto array = asArray()) {
         array->setFromVector(items);
     } else {
         typeWarning("array", "ignoring attempt to replace items");
diff --git a/libqpdf/QPDF_Array.cc b/libqpdf/QPDF_Array.cc
index 9593c31f..afec05af 100644
--- a/libqpdf/QPDF_Array.cc
+++ b/libqpdf/QPDF_Array.cc
@@ -35,7 +35,18 @@ QPDF_Array::QPDF_Array(
     QPDFValue(::ot_array, "array"),
     sparse(sparse)
 {
-    setFromVector(std::move(v));
+    if (sparse) {
+        sp_elements = SparseOHArray();
+        for (auto&& item: v) {
+            if (item->getTypeCode() != ::ot_null ||
+                item->getObjGen().isIndirect()) {
+                sp_elements.elements[sp_elements.n_elements] = std::move(item);
+            }
+            ++sp_elements.n_elements;
+        }
+    } else {
+        elements = std::move(v);
+    }
 }
 
 QPDF_Array::QPDF_Array(SparseOHArray const& items) :
@@ -207,33 +218,11 @@ QPDF_Array::setAt(int at, QPDFObjectHandle const& oh)
 void
 QPDF_Array::setFromVector(std::vector<QPDFObjectHandle> const& v)
 {
-    if (sparse) {
-        sp_elements = SparseOHArray();
-        for (auto const& iter: v) {
-            sp_elements.elements[sp_elements.n_elements++] = iter.getObj();
-        }
-    } else {
-        elements.resize(0);
-        for (auto const& iter: v) {
-            elements.push_back(iter.getObj());
-        }
-    }
-}
-
-void
-QPDF_Array::setFromVector(std::vector<std::shared_ptr<QPDFObject>>&& v)
-{
-    if (sparse) {
-        sp_elements = SparseOHArray();
-        for (auto&& item: v) {
-            if (item->getTypeCode() != ::ot_null ||
-                item->getObjGen().isIndirect()) {
-                sp_elements.elements[sp_elements.n_elements] = std::move(item);
-            }
-            ++sp_elements.n_elements;
-        }
-    } else {
-        elements = std::move(v);
+    elements.resize(0);
+    elements.reserve(v.size());
+    for (auto const& item: v) {
+        checkOwnership(item);
+        elements.push_back(item.getObj());
     }
 }
 
diff --git a/libqpdf/qpdf/QPDF_Array.hh b/libqpdf/qpdf/QPDF_Array.hh
index df814d74..d0138e5c 100644
--- a/libqpdf/qpdf/QPDF_Array.hh
+++ b/libqpdf/qpdf/QPDF_Array.hh
@@ -31,7 +31,6 @@ class QPDF_Array: public QPDFValue
     bool setAt(int n, QPDFObjectHandle const& oh);
     std::vector<QPDFObjectHandle> getAsVector() const;
     void setFromVector(std::vector<QPDFObjectHandle> const& items);
-    void setFromVector(std::vector<std::shared_ptr<QPDFObject>>&& items);
     bool insert(int at, QPDFObjectHandle const& item);
     void push_back(QPDFObjectHandle const& item);
     bool erase(int at);
-- 
cgit v1.2.3-54-g00ecf