From 788f6f7769c9f0b4b439079d87bbc180860fa14c Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Thu, 11 Aug 2011 15:22:59 -0400 Subject: fix small logic error surrounding adding newlines; in practice, the logic error would probably never manifest itself without other code changes --- libqpdf/QPDFWriter.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libqpdf/QPDFWriter.cc b/libqpdf/QPDFWriter.cc index 566a250b..3dcd7b82 100644 --- a/libqpdf/QPDFWriter.cc +++ b/libqpdf/QPDFWriter.cc @@ -1102,11 +1102,12 @@ QPDFWriter::unparseObject(QPDFObjectHandle object, int level, writeString("\nstream\n"); pushEncryptionFilter(); writeBuffer(stream_data); + char last_char = this->pipeline->getLastChar(); popPipelineStack(); if (this->qdf_mode) { - if (this->pipeline->getLastChar() != '\n') + if (last_char != '\n') { writeString("\n"); this->added_newline = true; @@ -1776,9 +1777,7 @@ QPDFWriter::writeHintStream(int hint_id) openObject(hint_id); setDataKey(hint_id); - unsigned char* hs = hint_buffer->getBuffer(); unsigned long hlen = hint_buffer->getSize(); - char last_char = hs[hlen - 1]; writeString("<< /Filter /FlateDecode /S "); writeString(QUtil::int_to_string(S)); @@ -1798,6 +1797,7 @@ QPDFWriter::writeHintStream(int hint_id) } pushEncryptionFilter(); writeBuffer(hint_buffer); + char last_char = this->pipeline->getLastChar(); popPipelineStack(); if (last_char != '\n') -- cgit v1.2.3-54-g00ecf