From 90217e6686fe2f3790f2a36d1ab74bab13a0aab5 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Tue, 20 Oct 2020 17:48:30 -0400 Subject: Fix another case of errors written to stdout (fixes #438) --- TODO | 1 - qpdf/qpdf.cc | 4 ++-- qpdf/qtest/qpdf/linearization-large-vector-alloc.out | 2 +- qpdf/qtest/qpdf/pages-loop.out | 2 +- qpdf/qtest/qpdf/split-content-stream-errors.out | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/TODO b/TODO index 90869bbf..e872e8b6 100644 --- a/TODO +++ b/TODO @@ -2,7 +2,6 @@ Candidates for upcoming release =============================== * Quick issues: - * #438: things written to stdout instead of stderr; --no-warn issues * Add --warning-exit-0 option. Search for --no-warn in the docs. * Easy build/test diff --git a/qpdf/qpdf.cc b/qpdf/qpdf.cc index 1cfbb04f..b7ac6fc0 100644 --- a/qpdf/qpdf.cc +++ b/qpdf/qpdf.cc @@ -3513,14 +3513,14 @@ static void do_check(QPDF& pdf, Options& o, int& exit_code) catch (QPDFExc& e) { okay = false; - std::cout << "page " << pageno << ": " + std::cerr << "ERROR: page " << pageno << ": " << e.what() << std::endl; } } } catch (std::exception& e) { - std::cout << e.what() << std::endl; + std::cerr << "ERROR: " << e.what() << std::endl; okay = false; } if (okay) diff --git a/qpdf/qtest/qpdf/linearization-large-vector-alloc.out b/qpdf/qtest/qpdf/linearization-large-vector-alloc.out index b4a16822..19049e31 100644 --- a/qpdf/qtest/qpdf/linearization-large-vector-alloc.out +++ b/qpdf/qtest/qpdf/linearization-large-vector-alloc.out @@ -5,4 +5,4 @@ File is linearized WARNING: linearization-large-vector-alloc.pdf (linearization hint stream: object 62 0, offset 1282): expected endstream WARNING: linearization-large-vector-alloc.pdf (linearization hint stream: object 62 0, offset 1183): attempting to recover stream length WARNING: linearization-large-vector-alloc.pdf (linearization hint stream: object 62 0, offset 1183): recovered stream length: 106 -overflow reading bit stream +ERROR: overflow reading bit stream diff --git a/qpdf/qtest/qpdf/pages-loop.out b/qpdf/qtest/qpdf/pages-loop.out index 08643aa4..a84ecb36 100644 --- a/qpdf/qtest/qpdf/pages-loop.out +++ b/qpdf/qtest/qpdf/pages-loop.out @@ -2,4 +2,4 @@ checking pages-loop.pdf PDF Version: 1.3 File is not encrypted File is not linearized -pages-loop.pdf (object 3 0): Loop detected in /Pages structure (getAllPages) +ERROR: pages-loop.pdf (object 3 0): Loop detected in /Pages structure (getAllPages) diff --git a/qpdf/qtest/qpdf/split-content-stream-errors.out b/qpdf/qtest/qpdf/split-content-stream-errors.out index 0486355f..de5fee75 100644 --- a/qpdf/qtest/qpdf/split-content-stream-errors.out +++ b/qpdf/qtest/qpdf/split-content-stream-errors.out @@ -6,4 +6,4 @@ WARNING: split-content-stream-errors.pdf (offset 557): error decoding stream dat WARNING: split-content-stream-errors.pdf (offset 557): stream will be re-processed without filtering to avoid data loss WARNING: page object 3 0 (item index 0 (from 0)): ignoring non-stream in an array of streams WARNING: split-content-stream-errors.pdf (offset 557): error decoding stream data for object 6 0: LZWDecoder: bad code received -page 1: content stream (content stream object 6 0): errors while decoding content stream +ERROR: page 1: content stream (content stream object 6 0): errors while decoding content stream -- cgit v1.2.3-54-g00ecf