From f8e4b6161cce4d851222dababb2c8c96e4b1c864 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Fri, 23 Oct 2020 14:25:21 -0400 Subject: With --no-warn, suppress warnings in split-pages Warnings issued on the output QPDF object were not suppressing warnings since that option was only set on the input QPDF object. --- qpdf/qpdf.cc | 4 ++++ qpdf/qtest/qpdf.test | 9 ++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/qpdf/qpdf.cc b/qpdf/qpdf.cc index 86cd6ad7..a1f9de8a 100644 --- a/qpdf/qpdf.cc +++ b/qpdf/qpdf.cc @@ -5593,6 +5593,10 @@ static void do_split_pages(QPDF& pdf, Options& o) } QPDF outpdf; outpdf.emptyPDF(); + if (o.suppress_warnings) + { + outpdf.setSuppressWarnings(true); + } for (size_t pageno = first; pageno <= last; ++pageno) { QPDFObjectHandle page = pages.at(pageno - 1); diff --git a/qpdf/qtest/qpdf.test b/qpdf/qtest/qpdf.test index 75021b56..60e5ba07 100644 --- a/qpdf/qtest/qpdf.test +++ b/qpdf/qtest/qpdf.test @@ -1724,7 +1724,7 @@ my @sp_cases = ( [1, 'broken data', '--pages broken-lzw.pdf --', 'split-out.pdf', {$td->FILE => "broken-lzw.out", $td->EXIT_STATUS => 3}], ); -$n_tests += 35; +$n_tests += 36; $n_compare_pdfs += 1; for (@sp_cases) { @@ -1845,6 +1845,13 @@ $td->runtest("unreferenced resources with bad token", $td->runtest("check output", {$td->FILE => "split-out-bad-token-1-2.pdf"}, {$td->FILE => "split-tokens-split-1-2.pdf"}); +$td->runtest("--no-warn with proxied warnings during split", + {$td->COMMAND => + "qpdf --qdf --static-id --split-pages=2" . + " --no-warn --remove-unreferenced-resources=yes" . + " split-tokens.pdf split-out-bad-token.pdf"}, + {$td->STRING => "", $td->EXIT_STATUS => 3}, + $td->NORMALIZE_NEWLINES); $td->runtest("shared images in form xobject", {$td->COMMAND => "qpdf --qdf --static-id --split-pages". -- cgit v1.2.3-54-g00ecf