From 2229e37e88a8d497b4a04725a46d181326a3fa45 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Fri, 4 Feb 2022 16:31:31 -0500 Subject: Add a blank line after the first header included in each source --- README-maintainer | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'README-maintainer') diff --git a/README-maintainer b/README-maintainer index 49dc643f..b43f183b 100644 --- a/README-maintainer +++ b/README-maintainer @@ -86,6 +86,15 @@ GOOGLE OSS-FUZZ CODING RULES +* In a source file, include the header file that declares the source + class first followed by a blank line. If a config file is needed + first, put a blank line between that and the header followed by + another blank line. This assures that each header file is included + first at least once, thereby ensuring that it explicitly includes + all the headers it needs, which in turn alleviates lots of header + ordering problems. The blank line ensures that formatters don't + messt his up by resorting the headers. + * Avoid atoi. Use QUtil::string_to_int instead. It does overflow/underflow checking. -- cgit v1.2.3-54-g00ecf