From 5b6cf45f8365562d805547b6ca774f2ba2a0c90f Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Tue, 21 Dec 2021 17:26:05 -0500 Subject: Cleanup TODO --- README-maintainer | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'README-maintainer') diff --git a/README-maintainer b/README-maintainer index 3ca9caf7..aaa0a61c 100644 --- a/README-maintainer +++ b/README-maintainer @@ -110,7 +110,16 @@ CODING RULES the shared library boundary. * Put private member variables in PointerHolder for all - public classes. Remember to use QPDF_DLL on ~Members(). + public classes. Remember to use QPDF_DLL on ~Members(). Exception: + indirection through PointerHolder is expensive, so don't do + it for classes that are copied a lot, like QPDFObjectHandle and + QPDFObject. + +* Traversal of objects is expensive. It's worth adding some complexity + to avoid needless traversals of objects. + +* Avoid attaching too much metadata to objects and object handles + since those have to get copied around a lot. RELEASE PREPARATION -- cgit v1.2.3-54-g00ecf