From 956a272d622af303859d7239c21272116c108b58 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Fri, 11 Feb 2022 07:17:51 -0500 Subject: Remove abs calls and pick correct floating point epsilon values (fixes #641) --- README-maintainer | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'README-maintainer') diff --git a/README-maintainer b/README-maintainer index 76a4c59c..4b36cf14 100644 --- a/README-maintainer +++ b/README-maintainer @@ -98,6 +98,11 @@ CODING RULES * Avoid atoi. Use QUtil::string_to_int instead. It does overflow/underflow checking. +* Avoid certain functions that tend to be macros or create compilation + errors on some platforms. Known cases: strcasecmp, abs. Avoid min + and max. If needed, std::min and std::max are okay to use in C++ + code with included. + * Remember to avoid using `operator[]` with `std::string` or `std::vector`. Instead, use `at()`. See README-hardening.md for details. -- cgit v1.2.3-54-g00ecf