From 5f3f78822b5d43e9b02082da5268d186ba7101c0 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sat, 5 Feb 2022 08:15:07 -0500 Subject: Improve use of std::unique_ptr * Use unique_ptr in place of shared_ptr in some cases * unique_ptr for arrays does not require a custom deleter * use std::make_unique (c++14) where possible --- TODO | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'TODO') diff --git a/TODO b/TODO index 222e200a..8166f090 100644 --- a/TODO +++ b/TODO @@ -1,6 +1,9 @@ 10.6 ==== +* Expose emptyPDF to the C API. Ensure that qpdf_get_qpdf_version is + always static. + * Consider doing one big commit to reformat the entire codebase using clang-format or a similar tool. Consider using blame.ignoreRevsFile or similar (or otherwise study git blame to see how to minimize the @@ -364,6 +367,13 @@ auto x_ph = std::make_shared(); X* x = x_ph.get(); Derived* x = new Derived(); PointerHolder x_ph(x) --> Derived* x = new Derived(); auto x_ph = std::shared_pointer(x); +Also remember + +auto x = std::shared_ptr(new T[5], std::default_delete()) +vs. +auto x = std::make_unique(5) + + PointerHolder in public API: QUtil::read_file_into_memory( -- cgit v1.2.3-54-g00ecf