From 90cfe80bacdd0d398631afce76c4182e08cc78b9 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sun, 10 Apr 2022 08:17:35 -0400 Subject: Clean up/fix DLL.h * Change DLL_EXPORT to libqpdf_EXPORTS (internal to the build). The new name is cmake's default, is more conventional, and is less likely to clash with other symbols. * Add QPDF_DLL_PRIVATE for non-Windows * Make logic around when to define QPDF_DLL et al more explicit * Add detailed comments --- TODO | 3 --- 1 file changed, 3 deletions(-) (limited to 'TODO') diff --git a/TODO b/TODO index 971b018f..ef34096c 100644 --- a/TODO +++ b/TODO @@ -37,9 +37,6 @@ cmake ===== * DLL.h - * Change DLL_EXPORT to QPDF_EXPORT. Be sure to call attention to - this in the release notes. There should be a "migrating to cmake" - in the manual, and ./configure should draw attention to it. * The effect of QPDF_DLL_CLASS is to export everything in the class, not just the vtable. On MSVC, we don't need this as the vtable gets exported automatically when needed. With gcc, we need it to -- cgit v1.2.3-54-g00ecf