From ef2b84c6c3af434882a192f2122e2dee3fbe5499 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sat, 9 Apr 2022 15:55:08 -0400 Subject: Enable PointerHolder warning and define POINTERHOLDER_IS_SHARED_POINTER --- include/qpdf/PointerHolder.hh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'include') diff --git a/include/qpdf/PointerHolder.hh b/include/qpdf/PointerHolder.hh index b51ca7ba..f0a513cb 100644 --- a/include/qpdf/PointerHolder.hh +++ b/include/qpdf/PointerHolder.hh @@ -22,16 +22,16 @@ #ifndef POINTERHOLDER_HH #define POINTERHOLDER_HH -#ifndef POINTERHOLDER_TRANSITION +#define POINTERHOLDER_IS_SHARED_POINTER -// In qpdf 11, #define POINTERHOLDER_IS_SHARED_POINTER +#ifndef POINTERHOLDER_TRANSITION -// In qpdf 11, issue a warning: // #define POINTERHOLDER_TRANSITION 0 to suppress this warning, and see below. -// # warn "POINTERHOLDER_TRANSITION is not defined -- see qpdf/PointerHolder.hh" +// See also https://qpdf.readthedocs.io/en/stable/design.html#smart-pointers +# warn "POINTERHOLDER_TRANSITION is not defined -- see qpdf/PointerHolder.hh" -// undefined = define as 0; will also issue a warning in qpdf 11 -// 0 = no deprecation warnings +// undefined = define as 0 and issue a warning +// 0 = no deprecation warnings, backward-compatible API // 1 = make PointerHolder(T*) explicit // 2 = warn for use of getPointer() and getRefcount() // 3 = warn for all use of PointerHolder -- cgit v1.2.3-54-g00ecf