From b6e414b10b3ae7b28ad16da2027106ec59a99a0a Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Sun, 12 Aug 2018 12:58:39 -0400 Subject: Remove some extraneous null pointer checks (fixes #234) There were a few places in the code that were checking that a pointer wasn't null before deleting it, even though C++ has always allowed delete 0. Most of the code did not perform these checks. --- libqpdf/Pl_RC4.cc | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'libqpdf/Pl_RC4.cc') diff --git a/libqpdf/Pl_RC4.cc b/libqpdf/Pl_RC4.cc index 87c17f83..407490ca 100644 --- a/libqpdf/Pl_RC4.cc +++ b/libqpdf/Pl_RC4.cc @@ -13,11 +13,8 @@ Pl_RC4::Pl_RC4(char const* identifier, Pipeline* next, Pl_RC4::~Pl_RC4() { - if (this->outbuf) - { - delete [] this->outbuf; - this->outbuf = 0; - } + delete [] this->outbuf; + this->outbuf = 0; } void @@ -47,10 +44,7 @@ Pl_RC4::write(unsigned char* data, size_t len) void Pl_RC4::finish() { - if (this->outbuf) - { - delete [] this->outbuf; - this->outbuf = 0; - } + delete [] this->outbuf; + this->outbuf = 0; this->getNext()->finish(); } -- cgit v1.2.3-54-g00ecf