From 2394acf7a688b2d080d4233d66a6e22bf46f0fca Mon Sep 17 00:00:00 2001
From: Jay Berkenbilt <ejb@ql.org>
Date: Tue, 13 Sep 2022 11:21:29 -0400
Subject: Remove explicit direct object check from getObject

An indirect object reference to 0, 0 is invalid. If it appears in the
file or is parsed from a string, the parser catches it. This check
would only be useful for someone explicitly calling getObject with 0,
0, and that would trigger an error during resolve().
---
 libqpdf/QPDF.cc | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'libqpdf/QPDF.cc')

diff --git a/libqpdf/QPDF.cc b/libqpdf/QPDF.cc
index 8a6831f9..f952aaee 100644
--- a/libqpdf/QPDF.cc
+++ b/libqpdf/QPDF.cc
@@ -1781,9 +1781,8 @@ QPDF::readObjectAtOffset(
         // not triggered by an xref lookup.
         check_og = false;
         try_recovery = false;
-    } else {
-        setLastObjectDescription(description, exp_og);
     }
+    setLastObjectDescription(description, exp_og);
 
     if (!this->m->attempt_recovery) {
         try_recovery = false;
@@ -2190,9 +2189,6 @@ QPDF::reserveStream(QPDFObjGen const& og)
 QPDFObjectHandle
 QPDF::getObject(QPDFObjGen const& og)
 {
-    if (!og.isIndirect()) {
-        return QPDFObjectHandle::newNull();
-    }
     if (!isCached(og)) {
         m->obj_cache[og] = ObjCache(QPDF_Unresolved::create(this, og), -1, -1);
     }
-- 
cgit v1.2.3-70-g09d2