From c4e56fa5f40188ddf4f75d316e57143c10ed51fa Mon Sep 17 00:00:00 2001
From: Jay Berkenbilt <ejb@ql.org>
Date: Sun, 23 Jan 2022 13:04:08 -0500
Subject: QPDFJob: make createsOutput callable before run()

---
 libqpdf/QPDFJob.cc | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

(limited to 'libqpdf/QPDFJob.cc')

diff --git a/libqpdf/QPDFJob.cc b/libqpdf/QPDFJob.cc
index 0a394745..0c772efb 100644
--- a/libqpdf/QPDFJob.cc
+++ b/libqpdf/QPDFJob.cc
@@ -322,7 +322,6 @@ ProgressReporter::reportProgress(int percentage)
 QPDFJob::Members::Members() :
     message_prefix("qpdf"),
     warnings(false),
-    creates_output(false),
     cout(&std::cout),
     cerr(&std::cerr),
     encryption_status(0)
@@ -500,8 +499,7 @@ QPDFJob::run()
     handleUnderOverlay(pdf);
     handleTransformations(pdf);
 
-    this->m->creates_output = ((o.outfilename != nullptr) || o.replace_input);
-    if (! this->m->creates_output)
+    if (! createsOutput())
     {
         doInspection(pdf);
     }
@@ -526,9 +524,10 @@ QPDFJob::hasWarnings()
 }
 
 bool
-QPDFJob::createsOutput()
+QPDFJob::createsOutput() const
 {
-    return this->m->creates_output;
+    QPDFJob const& o = *this; // QXXXQ
+    return ((o.outfilename != nullptr) || o.replace_input);
 }
 
 bool
-- 
cgit v1.2.3-54-g00ecf