From 585ecf17c87d86c6fb07ebbbef703a8a859680f2 Mon Sep 17 00:00:00 2001
From: m-holger <m-holger@kubitscheck.org>
Date: Tue, 15 Nov 2022 10:49:00 +0000
Subject: Remove redundant parameter cross_indirect from
 QPDFObjectHandle::copyObject

---
 libqpdf/QPDFObjectHandle.cc | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

(limited to 'libqpdf')

diff --git a/libqpdf/QPDFObjectHandle.cc b/libqpdf/QPDFObjectHandle.cc
index 4db119a7..3362d5e6 100644
--- a/libqpdf/QPDFObjectHandle.cc
+++ b/libqpdf/QPDFObjectHandle.cc
@@ -2219,7 +2219,7 @@ QPDFObjectHandle::unsafeShallowCopy()
 
 void
 QPDFObjectHandle::copyObject(
-    std::set<QPDFObjGen>& visited, bool cross_indirect, bool stop_at_streams)
+    std::set<QPDFObjGen>& visited, bool stop_at_streams)
 {
     assertInitialized();
     if (isStream()) {
@@ -2259,10 +2259,7 @@ QPDFObjectHandle::copyObject(
         int n = array->getNItems();
         for (int i = 0; i < n; ++i) {
             items.push_back(array->getItem(i));
-            if ((cross_indirect || (!items.back().isIndirect()))) {
-                items.back().copyObject(
-                    visited, cross_indirect, stop_at_streams);
-            }
+            items.back().copyObject(visited, stop_at_streams);
         }
         new_obj = QPDF_Array::create(items);
     } else if (isDictionary()) {
@@ -2270,9 +2267,7 @@ QPDFObjectHandle::copyObject(
         auto dict = asDictionary();
         for (auto const& key: getKeys()) {
             items[key] = dict->getKey(key);
-            if ((cross_indirect || (!items[key].isIndirect()))) {
-                items[key].copyObject(visited, cross_indirect, stop_at_streams);
-            }
+            items[key].copyObject(visited, stop_at_streams);
         }
         new_obj = QPDF_Dictionary::create(items);
     } else {
@@ -2309,7 +2304,7 @@ void
 QPDFObjectHandle::makeDirect(bool allow_streams)
 {
     std::set<QPDFObjGen> visited;
-    copyObject(visited, true, allow_streams);
+    copyObject(visited, allow_streams);
 }
 
 void
-- 
cgit v1.2.3-54-g00ecf