From 5c5b4e640e2df248192ff7aa518fb0d345884a33 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Thu, 6 Oct 2022 08:05:48 -0400 Subject: Be more conservative about QPDF_DLL_CLASS with mingw (fixes #799) * Define it even though previous experiments have shown it to be unnecessary since it seems like it may be necessary after all * Add QPDF_DLL_CLASS to QPDFObjectHelper and QPDFDocumentHelper in case there's some future unknown reason why someone may want to have them and/or in case it helps with the weird QPDFNameTreeObjectHelper problem. --- libqpdf/CMakeLists.txt | 2 ++ libqpdf/QPDFDocumentHelper.cc | 7 +++++++ libqpdf/QPDFObjectHelper.cc | 7 +++++++ 3 files changed, 16 insertions(+) create mode 100644 libqpdf/QPDFDocumentHelper.cc create mode 100644 libqpdf/QPDFObjectHelper.cc (limited to 'libqpdf') diff --git a/libqpdf/CMakeLists.txt b/libqpdf/CMakeLists.txt index 7053e205..5e3a628e 100644 --- a/libqpdf/CMakeLists.txt +++ b/libqpdf/CMakeLists.txt @@ -59,6 +59,7 @@ set(libqpdf_SOURCES QPDFAnnotationObjectHelper.cc QPDFArgParser.cc QPDFCryptoProvider.cc + QPDFDocumentHelper.cc QPDFEFStreamObjectHelper.cc QPDFEmbeddedFileDocumentHelper.cc QPDFExc.cc @@ -74,6 +75,7 @@ set(libqpdf_SOURCES QPDFNumberTreeObjectHelper.cc QPDFObject.cc QPDFObjectHandle.cc + QPDFObjectHelper.cc QPDFObjGen.cc QPDFOutlineDocumentHelper.cc QPDFOutlineObjectHelper.cc diff --git a/libqpdf/QPDFDocumentHelper.cc b/libqpdf/QPDFDocumentHelper.cc new file mode 100644 index 00000000..ad23e6f8 --- /dev/null +++ b/libqpdf/QPDFDocumentHelper.cc @@ -0,0 +1,7 @@ +#include + +QPDFDocumentHelper::~QPDFDocumentHelper() +{ + // Must be explicit and not inline -- see QPDF_DLL_CLASS in + // README-maintainer +} diff --git a/libqpdf/QPDFObjectHelper.cc b/libqpdf/QPDFObjectHelper.cc new file mode 100644 index 00000000..3696dc03 --- /dev/null +++ b/libqpdf/QPDFObjectHelper.cc @@ -0,0 +1,7 @@ +#include + +QPDFObjectHelper::~QPDFObjectHelper() +{ + // Must be explicit and not inline -- see QPDF_DLL_CLASS in + // README-maintainer +} -- cgit v1.2.3-54-g00ecf