From 8a3cdfd2af4a95d8daede45bcb36eecdcdc8f964 Mon Sep 17 00:00:00 2001 From: Jay Berkenbilt Date: Fri, 9 Sep 2022 15:40:02 -0400 Subject: Change QPDFObjectHandle == to isSameObjectAs Replace operator== and operator!=, which were testing for the same underlying object, with isSameObjectAs. This change was motivated by the fact that pikepdf internally had its own operator== method for QPDFObjectHandle that did structural comparison. I backed out qpdf's operator== as a courtesy to pikepdf (in my own testing) but also because I think people might naturally assume that operator== does a structural comparison, and isSameObjectAs is clearer in its intent. --- manual/release-notes.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'manual/release-notes.rst') diff --git a/manual/release-notes.rst b/manual/release-notes.rst index bb9bdb7f..694b28e0 100644 --- a/manual/release-notes.rst +++ b/manual/release-notes.rst @@ -231,12 +231,12 @@ For a detailed list of changes, please see the file still valid, but it's also possible to have direct objects that don't have an owning ``QPDF``. - - It is now possible to test ``QPDFObjectHandle`` equality with - ``==`` and ``!=``. Two ``QPDFObjectHandle`` objects are equal if - they point to the same underlying object, meaning changes to one - will be reflected in the other. Note that this method does not - compare the contents of the objects, so two distinct but - structurally identical objects will not be considered equal. + - Add method ``QPDFObjectHandle::isSameObjectAs`` for testing + whether two ``QPDFObjectHandle`` objects point to the same + underlying object, meaning changes to one will be reflected in + the other. Note that this method does not compare the contents + of the objects, so two distinct but structurally identical + objects will not be considered the same object. - New factory method ``QPDF::create()`` returns a ``std::shared_ptr``. -- cgit v1.2.3-54-g00ecf