code-style: misc changes (#374)

* ensure static variables comes after non-static ones
* remove depreciated DATA32 type
* prefer `sizeof(expression)` over `sizeof(Type)`.
* silence a -Wsign warning
* {gif,webp} loader: use a pointer to reduce code-noise
* gif loader: allocate in one place

Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/374
Reviewed-by: TAAPArthur <taaparthur@noreply.codeberg.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/util.c b/util.c
index 8b164ed..9172e85 100644
--- a/util.c
+++ b/util.c
@@ -97,7 +97,7 @@ int r_opendir(r_dir_t *rdir, const char *dirname, bool recursive)
 	}
 
 	rdir->stcap = 512;
-	rdir->stack = emalloc(rdir->stcap * sizeof(char*));
+	rdir->stack = emalloc(rdir->stcap * sizeof(*rdir->stack));
 	rdir->stlen = 0;
 
 	rdir->name = (char*) dirname;
@@ -164,7 +164,7 @@ char* r_readdir(r_dir_t *rdir, bool skip_dotfiles)
 				if (rdir->stlen == rdir->stcap) {
 					rdir->stcap *= 2;
 					rdir->stack = erealloc(rdir->stack,
-					                       rdir->stcap * sizeof(char*));
+					                       rdir->stcap * sizeof(*rdir->stack));
 				}
 				rdir->stack[rdir->stlen++] = filename;
 				continue;