aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJay Berkenbilt <jberkenbilt@users.noreply.github.com>2024-02-03 18:28:51 +0100
committerGitHub <noreply@github.com>2024-02-03 18:28:51 +0100
commitaea885aab292abfb583232f0069ee47acbd94bbd (patch)
tree42ca1c90682506b2860dba79a4ffd4ba194e2c1d
parente641a883cd4475671a01c006e4c801f6297ee836 (diff)
parente93c5ec993c6bb64452a064fe4968da79dabcb52 (diff)
downloadqpdf-aea885aab292abfb583232f0069ee47acbd94bbd.tar.zst
Merge pull request #1136 from m-holger/todo
Update TODO.md regarding indirect nulls in QPDF_Dictionary
-rw-r--r--TODO.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/TODO.md b/TODO.md
index 0f12696f..938fda93 100644
--- a/TODO.md
+++ b/TODO.md
@@ -337,9 +337,9 @@ so, I find it useful to make reference to them in this list.
Note that there's nothing that says an indirect object in one update can't refer to an object that
doesn't appear until a later update. This means that QPDF has to hang onto indirect nulls,
including when they appear as dictionary values. In this case, QPDF_Dictionary::getKeys() ignores
- all keys with null values, and hasKey() returns false for keys that have null values. We would
- probably want to make QPDF_Dictionary able to handle the special case of keys that are indirect
- nulls and basically never have it drop any keys that are indirect objects. We also have to make
+ all keys with null values, and hasKey() returns false for keys that have null values. QPDF_Dictionary
+ already handles the special case of keys that are indirect nulls, which is used to reserve foreign
+ objects, including foreign pages which may or may not be copied. We also have to make
sure that the testing for this handles non-trivial cases of the targets of indirect nulls being
replaced by real objects in an update. Such indirect nulls should appear in tests as dictionary
values and as array values. In the distant past, qpdf used to replace indirect nulls with direct