Bug fix: content normalizer should not add trailing newline

Adding a trailing newline in content normalization damages files whose
contents are split across streams in the middle of tokens. Let
QPDFWriter add the newline with the indicator to ignore the newline,
which it already does. This changes the way some qdf files look.

1 files changed, 16 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index fd323e44..39a7cbf7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -62,6 +62,22 @@
 	QPDFObjectHandle::parsePageContents() method in favor of the older
 	QPDFObjectHandle::parseContentStream() method.
 
+	* Bug fix: change where the trailing newline is added to a stream
+	in QDF mode when content normalization is enabled (the default for
+	QDF mode). Before, the content normalizer ensured that the output
+	ended with a trailing newline, but this had the undesired side
+	effect of including the newline in the stream data for purposes of
+	length computation. QPDFWriter already appends a newline without
+	counting in length for better readability. Ordinarily this makes
+	no difference, but in the rare case of a page's contents being
+	split in the middle of a token, the old behavior could cause the
+	extra newline to be interprted as part of the token. This bug
+	could only be triggered in qdf mode, which is a mode intended for
+	manual inspection of PDF files' contents, so it is very unlikely
+	to have caused any actual problems for people using qpdf for
+	production use. Even if it did, it would be very unusual for a PDF
+	file to actually be adversely affected by this issue.
+
 2018-02-04  Jay Berkenbilt  <ejb@ql.org>
 
 	* Add QPDFWriter::setLinearizationPass1Filename method and